cvs commit: src/lib/libarchive Makefile

[Bruce Evans]

On Thu, 12 Feb 2004, juli mallett wrote:

> * Dag-Erling Sm=F8rgrav <des at des.no> [ Date: 2004-02-12 ]
> =09[ w.r.t. Re: cvs commit: src/lib/libarchive Makefile ]
> > Tim Kientzle <kientzle at FreeBSD.org> writes:
> > >   Log:
> > >   libarchive itself is now completely clean at WARNS=3D10 on all arch=
itectures.
> > >
> > >   Unfortunately, the stock zlib.h is not:
> > >     line 885: 'err' parameter shadows global 'err' definition from <e=
rr.h>
> >
> > This is trivial to fix, if we're willing to take zlib.h off the vendor
> > branch or manage to convince Gailly to take our patch.
>
> Personally, I'm against prototype declarations in headers being
> warning checked for parameter names, even moreso for headers not
> included within the headers in question.

We force checking of system (including standard) headers using
-Wsystem-headers, and I think this checking applies here.  I wouldn't
want to turn of checking for all warnings in system headers.

Anyway, names like "err" in system headers are just bugs.  They break
application code like:

#define=09err=09if you can see this, then <zlib.h> is broken
#include <zlib.h>

zlib.h has many such bugs.  It looks like an application header that
escaped to become a system header.

Bruce