cvs commit: ports/www/firefox Makefile distinfo pkg-descr pkg-message pkg-plist ports/www/firefox/files firebird.rb firefox.rb mkdistfile mozconfig.in patch-Double.cpp patch-build_unix_run-mozilla

[Kris Kennaway]

On Thu, Feb 12, 2004 at 11:16:58AM +0100, Dag-Erling Sm?rgrav wrote:
> Trevor Johnson <trevor at jpj.net> writes:
> > > The "added dependency" argument is specious as it is only true for
> > > RELENG_4_6 and earlier.
> > grep OSVERSION /usr/ports/Mk/bsd.port.mk
> 
> what exactly are you trying to prove?
> 
> .if defined(USE_REINPLACE)
> REINPLACE_ARGS?=        -i.bak
> .if ${OSVERSION} < 460101 || ( ${OSVERSION} >= 500000 && ${OSVERSION} < 500036 )
> PATCH_DEPENDS+= ${LOCALBASE}/bin/sed_inplace:${PORTSDIR}/textproc/sed_inplace
> REINPLACE_CMD?= ${LOCALBASE}/bin/sed_inplace ${REINPLACE_ARGS}
> .else
> REINPLACE_CMD?= ${SED} ${REINPLACE_ARGS}
> .endif
> 
> BTW, I don't see why REINPLACE_CMD couldn't simply be ${PERL} -p
> ${REINPLACE_ARGS} on systems that don't have sed -i, since both 4.x
> and 5.x prior to 500036 have Perl in the base system.

AFAIK we used to do this, but perl and sed regexps are not always
interchangeable, and it was a real pain to keep fixing them so they
were.

Kris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20040212/2149b6c5/attachment.bin