cvs commit: ports/print/gv Makefile distinfo pkg-descrpkg-plist ports/print/gv/files patch-aa patch-ab patch-ac patch-ad patch-source::gv_misc_res.dat patch-source::paths.h patch-source::ps.c patch-source::secscanf.c patch-src::Makefile.in patch-src::file.c ...

[Gerald Pfeifer]

On Thu, 30 Dec 2004, Kirill Ponomarew wrote:
>   Log:
>   Update to version 3.6.1
>   
>   PR:             ports/75627

Yeah.  

Incidently, I started working on this update yesterday as well...

>   1.1       +13 -0     ports/print/gv/files/patch-src::file.c (new)

...and found a better (more portable) fix for this which I already 
submitted upstream and got a positive response from the maintainer.

My testing of the updated port shows that the packaging list not correct.  
The port now leaves

  $PREFIX/lib/X11/gv/gv_spartan.dat
  $PREFIX/lib/X11/gv/gv_user_res.dat
  $PREFIX/lib/X11/gv/gv_copyright.dat

behind.  Would you mind having a look?

>   1.1       +10 -0     ports/print/gv/files/patch-src::gv_misc_res.dat (new)
>   1.1       +20 -0     ports/print/gv/files/patch-src::main.c (new)
>   1.1       +22 -0     ports/print/gv/files/patch-src::ps.c (new)
>   1.1       +20 -0     ports/print/gv/files/patch-src::resource.c (new)

Have all the other ones been submitted upstream as well?

That's the only way to really educate developers on portability (see how 
much Wine has improved in that build failures on non-Linux platforms got 
increasingly rare!) and helps us maintain our ports in the long term.

+ CPPFLAGS=       -I${X11BASE}/include

is only needed due to a bug upstream which should be fixed there, not
worked around.  I'll discuss this with the upstream maintainer.


Also, some of the patches shouldn't be needed for FreeBSD, unless one 
wants to use a strict ISO compiler: patch-src::main.c, patch-src::ps.c, 
patch-src::resource.c.  Do we really want this in our ports collection?
(If someone cares, he really should submit upstream and we'll get it via
the next update.)

Gerald
-- 
Gerald Pfeifer (Jerry)   gerald at pfeifer.com   http://www.pfeifer.com/gerald/