cvs commit: ports/x11-themes/gtk-aluminumalloy-cryogenic-theme pkg-plist ports/x11-themes/gtk-aluminumalloy-smog-theme pkg-plist ports/x11-themes/gtk-aluminumalloy-toxic-theme pkg-plist ports/x11-themes/gtk-aluminumalloy-volcanic-theme pkg-plist

[Jeremy Messenger]

On Mon, 20 Dec 2004 07:09:26 +0000 (UTC), Alexey Dokuchaev  
<danfe at FreeBSD.org> wrote:

> danfe       2004-12-20 07:09:25 UTC
>
>   FreeBSD ports repository
>
>   Modified files:
>     x11-themes/gtk-aluminumalloy-cryogenic-theme pkg-plist
>     x11-themes/gtk-aluminumalloy-smog-theme pkg-plist
>     x11-themes/gtk-aluminumalloy-toxic-theme pkg-plist
>     x11-themes/gtk-aluminumalloy-volcanic-theme pkg-plist
>   Log:
>   Remove directory that might be empty.

Why not depend on gtk and metacity? You can't use those theme without gtk  
and metacity. If you depend on those and you won't have that pkg-plist  
problem. Suggest to change like this:

==========================================
.if ${TYPE} == "gtk"
+USE_GNOME=gtk20
THEME_DIR=${PREFIX}/share/themes/${THEME_NAME}
PLIST_SUB+=GTK20=""
PLIST_SUB+=METACITY="@comment "
.else# metacity
+USE_GNOME=metacity
THEME_DIR=${PREFIX}/share/gnome/themes/${THEME_NAME}
PLIST_SUB+=GTK20="@comment "
PLIST_SUB+=METACITY=""
.endif
==========================================

But, what if a user want to have both gtk and metacity?

Cheers,
Mezz

>   Noticed by:     kris


-- 
mezz7 at cox.net  -  mezz at FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/  -  gnome at FreeBSD.org