cvs commit: ports/math/fftw3 Makefile ports/math/fftw3/files patch-alloc.c

[Michael Johnson]

On Dec 9, 2004, at 4:48 PM, Kris Kennaway wrote:

> On Thu, Dec 09, 2004 at 04:33:03PM -0500, Michael Johnson wrote:
>>
>> On Dec 9, 2004, at 4:29 PM, Kris Kennaway wrote:
>>
>>> On Thu, Dec 09, 2004 at 07:21:04PM +0000, Michael Johnson wrote:
>>>> ahze        2004-12-09 19:21:04 UTC
>>>>
>>>>  FreeBSD ports repository
>>>>
>>>>  Modified files:
>>>>    math/fftw3           Makefile
>>>>    math/fftw3/files     patch-alloc.c
>>>>  Log:
>>>>  - Add note about WITH_OPTIMIZED_ATHLON will fall back to 3dNow if
>>>> you don't have
>>>>    a Athlon
>>>
>>> Why not just use the CPU feature list from <bsd.cpu.mk>, so it
>>> automatically DTRT when CPUTYPE is set?
>>
>>
>> Should I do it like...
>>
>> .if ${CPUTYE}=="athlon" || ${CPUTYPE}=="athlon-xp" ||
>> ${CPUTYPE}=="k6-3" || ${CPUTYPE}=="k6-2" ... etc
>> ..code...
>> .endif
>>
>> ??
>
> No, see e.g. mpg123

ahh, thanks

Should I remove the OPTION and always use that if the cpu has 3dnow or 
still give an option to do it?
>
> Kris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20041209/8eac0250/PGP.bin