cvs commit: src/sys/geom/concat g_concat.c src/sys/geom/label g_label.c src/sys/geom/mirror g_mirror.c src/sys/geom/raid3 g_raid3.c src/sys/geom/stripe g_stripe.c

[Pawel Jakub Dawidek]

On Thu, Aug 26, 2004 at 05:29:21PM +0400, Roman Kurakin wrote:
+> >Yes, I know that it should be done this way, but I'm not going to fix
+> >atapi-cd.c, scsi_da.c and scsi_cd.c and who knows what else.
+> >Those classes set error to 0 even when provider has not sectorsize
+> >and mediasize defined.
+> > 
+> >
+> Does your code print any warning message in that case?
+> That could force authors of 'buggy' code to fix it.

No, this should be KASSERT() inside g_error_provider():

KASSERT(error == 0 && pp->sectorsize > 0 && pp->mediasize > 0, ("Buggy code."));

-- 
Pawel Jakub Dawidek                       http://www.FreeBSD.org
pjd at FreeBSD.org                           http://garage.freebsd.pl
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20040826/84955b64/attachment.bin