cvs commit: src/release Makefile

John Baldwin jhb at FreeBSD.org
Mon Aug 16 06:59:40 PDT 2004


On Monday 16 August 2004 09:37 am, John Baldwin wrote:
> On Monday 16 August 2004 04:28 am, David E. O'Brien wrote:
> > obrien      2004-08-16 08:28:58 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     release              Makefile
> >   Log:
> >   Accept the fact that floppies either aren't applicable or relevant on
> > most platforms.  So make the floppy logic easier to read.
>
> Please revert this unreviewed commit.  I like to build releases at work
> with 'NO_FLOPPIES=yes' on i386 just so I can skip the extra time spent
> building floppies when I only do installs over FTP and CD-ROM.  Changing
> the sense of the knob breaks that feature.  This also has basically zero
> impact as far as readability.

Well, I see you did fix this eventually but it sure would be nice if you would 
get gratuitous code churn reviewed first.

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org


More information about the cvs-all mailing list