cvs commit: src/usr.bin/patch - Imported sources

Garance A Drosehn gad at FreeBSD.org
Sun Aug 1 21:54:44 PDT 2004


At 10:45 AM +0700 8/2/04, Alexey Dokuchaev wrote:
>On Sun, Aug 01, 2004 at 08:45:55PM +0000, Garance A Drosehn wrote:
>  >  
>>    Log Message:
>  >   Import of a BSD-licensed version of `patch', ....
>  >   Among other things, this version includes a --posix option
>  >   for strict POSIX conformance.
>  >
>  >   This version is the current source from OpenBSD as of ...
>
>May I ask why you preferred OpenBSD's version over NetBSD's?

The last thing I imported was pkill, and I imported that from
NetBSD.  Seemed fair to take this from OpenBSD.  OpenBSD also
had done the --posix work, which seemed like a good starting
point.

Also, OpenBSD had already gone through and made many style(9)
changes, such as changing the indent from 2 blanks to 1 tab.
It seemed sub-optimal to import something, and then bloat the
CVS repository by having to change almost every line due to
style issues.

The end result is going to be about the same, since my intent
is to make whatever changes we need to make.  The plan includes
pulling in changes from whichever BSD was not used as the import.

>It was shown in the past that OpenBSD's way of doing thing is
>a bit rough on the edges sometimes (humanize_number(3) vs.
>fmt_scaled(3) and scan_scaled(3), ftw(3) and nftw(3), etc).

If there are edges that we don't like, we can change them.  In
my opinion it is hopeless to treat this as a "standard vendor
import" and to *also* combine all changes from Free/Net/Open,
so I am not going to lose any sleep over changing things that
need to be changed.  If it wasn't for the fact that FreeBSD
moved patch from usr.bin to gnu/usr.bin many years ago, I would
not even bother with an import.  I'd just fix the source which
would already be sitting in this directory -- instead of sitting
in the Attic where it can screw up my import!

-- 
Garance Alistair Drosehn     =      gad at gilead.netel.rpi.edu
Senior Systems Programmer               or   gad at FreeBSD.org
Rensselaer Polytechnic Institute;             Troy, NY;  USA


More information about the cvs-all mailing list