cvs commit: src/sys/boot/i386/boot0 Makefile boot0.s boot0_512.s boot0sio.s

Ruslan Ermilov ru at freebsd.org
Wed Apr 28 00:37:22 PDT 2004


On Wed, Apr 28, 2004 at 02:52:39PM +1000, Bruce Evans wrote:
> On Tue, 27 Apr 2004, Ruslan Ermilov wrote:
> 
> > On Tue, Apr 27, 2004 at 12:07:35PM -0700, Poul-Henning Kamp wrote:
> > > phk         2004/04/27 12:07:35 PDT
> > >
> > >   FreeBSD src repository
> > >
> > >   Modified files:
> > >     sys/boot/i386/boot0  Makefile
> > >   Added files:
> > >     sys/boot/i386/boot0  boot0_512.s
> > >   Removed files:
> > >     sys/boot/i386/boot0  boot0.s boot0sio.s
> > >   Log:
> > >   Change from '#' to "//" comment character to allow CPP preprocessing.
> > >
> > This is backwards, please fix.  Also, the preprocessed files
> 
> So "# foo" is a valid comment and not a preprocessor directive in *.S
> provided "foo" is not a standard preprocessor directive?
> 
Hmm, no it's not.  I will fix all .S files under sys/boot/ to use
a proper syntax for single-line comments (`//').  Only lines that
_start_ with `#' need to be fixed.

My main point still applies: adding a special CPP preprocessing
to this makefile was backwards, having the .S file is enough,
though I confirm that I was confused about single-line comments
in the mixed (assmebler + CPP) input.  Reading the cpp.info now
revealed the truth.

Nevertheless, I've ordered a repo-copy of boot0sio.s to boot0.S.


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20040428/2339d588/attachment.bin


More information about the cvs-all mailing list