cvs commit: src/sys/net radix.c

Luigi Rizzo luigi at FreeBSD.org
Wed Apr 21 08:27:37 PDT 2004


luigi       2004/04/21 08:27:36 PDT

  FreeBSD src repository

  Modified files:
    sys/net              radix.c 
  Log:
  Readability fixes:
  
  Clearly comment the assumptions on the structure of keys (addresses)
  and masks, and introduce a macro, LEN(p), to extract the size of these
  objects instead of using *(u_char *)p which might be confusing.
  
  Comment the confusion in the types used to pass around pointers
  to keys and masks, as a reminder to fix that at some point.
  
  Add a few comments on what some functions do.
  
  Comment a probably inefficient (but still correct) section of code
  in rn_walktree_from()
  
  The object code generated after this commit is the same as before.
  
  At some point we should also change same variable identifiers such
  as "t, tt, ttt" to fancier names such as "root, left, right" (just
  in case someone wants to understand the code!), replace misspelling
  of NULL as 0, remove 'register' declarations that make little sense
  these days.
  
  Revision  Changes    Path
  1.36      +76 -12    src/sys/net/radix.c


More information about the cvs-all mailing list