cvs commit: src/usr.bin/tar bsdtar.c bsdtar.h write.c

Bruce Evans bde at zeta.org.au
Wed Apr 14 05:56:42 PDT 2004


On Wed, 14 Apr 2004, [iso-8859-1] Dag-Erling Sm=F8rgrav wrote:

> Alexey Dokuchaev <danfe at nsu.ru> writes:
> > On Tue, Apr 13, 2004 at 07:15:26PM -0700, Alfred Perlstein wrote:
> > > While I applaud the effort here, it is a major violation of C
> > > POLA to have compilable code within a header file.
> > Seconded.  Please keep *.h code-free.
>
> What are you guys all smoking?  Did you even look at the file in
> question?

The file does claim to do bad things in a comment:

% /* Data for exclusion/inclusion handling: defined in matching.c */
% struct matching;
% struct links_entry;
% struct archive_dir_entry;

Contrary to the comment, there is no data definition or even data
declaration here,  There are only bogus unsorted forward declarations
here.  These style bugs are not new; they were in rev.1.1.

Bruce


More information about the cvs-all mailing list