cvs commit: src/sys/sys cdefs.h

[Peter Wemm]

Bruce Evans wrote:
> On Fri, 31 Oct 2003, Ruslan Ermilov wrote:
> 
> > On Sat, Nov 01, 2003 at 12:34:51AM +1100, Bruce Evans wrote:
> > > The system shouldn't have to satisfy cleanness standards of applications
> > > that are not maintained by FreeBSD, especially when those standards
> > > are bogus (e.g., compiling cleanly with -Wundef).  Hopefull all the
> > > important corner cases in the system headers are tested by buildworld
> > > so that we don't need to enlist the application maintainers to find bugs
> > > in system headers.
> > >
> > Now that buildworld and normal builds behave the same, I tend to agree.
> > Count this as "no objection" to revert this.
> 
> Thanks.
> 
> I think -Wsystem-headers needs to be set even when WARNS is not set (or
> is 0) for world builds to actually be the same (if toplev.c doesn't set
> it by default).  Then there would be another aspect of the old problem
> that bsd.*.mk aren't entirely suitable for non-FreeBSD builds.

I'm a little uneasy about this FWIW.  I'll defer to Alexander on this one.
If he's ok with the changes you want, then so am I.  So long as there is a
solution so that Nearly Every Port In Existence doesn't complain about
cdefs.h, I will not stand in the way.

Cheers,
-Peter
--
Peter Wemm - peter at wemm.org; peter at FreeBSD.org; peter at yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5