cvs commit: ports/net/lft Makefile ports/net/lft/files patch-lft.c

[Peter Pentchev]

On Wed, Oct 01, 2003 at 07:12:16AM -0700, Scott Likens wrote:
> On Wed, 2003-10-01 at 06:39, Peter Pentchev wrote:
> > On Tue, Sep 30, 2003 at 05:27:42AM -0700, Edwin Groothuis wrote:
> > > edwin       2003/09/30 05:27:42 PDT
> > > 
> > >   FreeBSD ports repository
> > > 
> > >   Modified files:
> > >     net/lft              Makefile 
> > >     net/lft/files        patch-lft.c 
> > >   Log:
> > >   patch for net/lft
> > >   
> > >           ports/net/lft has a slight problem on 4.x servers
> > >   
> > >           GCC 2.95 does not support atol on 4.x, where as 5.x has
> > >           atol, to solve this slight problem we must use either a
> > >           version check, or use depreciated atoll
> > >   
> > >   Informed maintainer.
> > 
> > However, my 4.9-RC doesn't have atoll(3) at all - neither as a manpage,
> > nor even in the src/lib/libc/stdlib/ sources.  How about the following
> > patch, which makes it use strtoll(3) instead?
> 
> Yes, 4.x does not have atol, it should have atoll instead.  If this can
> be verified that atoll has been removed from 4.9 please let me know. 
> But rest assured, it is there.  If not, some major catastrophy has
> happened and the world has ended.

Errrr... I do believe it's the other way 'round: -STABLE has atol(3),
and it does not (and never has, IMHO) have atoll(3).  A quick look
at the difference between
http://www.freebsd.org/cgi/cvsweb.cgi/src/lib/libc/stdlib/?only_with_tag=RELENG_4
http://www.freebsd.org/cgi/cvsweb.cgi/src/lib/libc/stdlib/
will show you that -CURRENT has an atoll.c file there now, while -STABLE
still has only atol.c, which does not contain an atoll() function.

Also,

[roam at straylight ~]> find /usr/src/lib -type f | xargs fgrep -l atoll
[roam at straylight ~]>

This was on a 4.9-RC cvsup'd today.

I rest my case about using the C99 strtoll() instead.

G'luck,
Peter

-- 
Peter Pentchev	roam at ringlet.net    roam at sbnd.net    roam at FreeBSD.org
PGP key:	http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint	FDBA FD79 C26F 3C51 C95E  DF9E ED18 B68D 1619 4553
.siht ekil ti gnidaer eb d'uoy ,werbeH ni erew ecnetnes siht fI
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20031001/ae707eea/attachment.bin