cvs commit: src/sbin/newfs mkfs.c

Bruce Evans bde at zeta.org.au
Fri May 23 02:04:16 PDT 2003


On Thu, 22 May 2003, Doug Barton wrote:

> On Thu, 22 May 2003, Nate Lawson wrote:
>
> > Actually there's a style bug in that the chdummy line is spaces not
> > tabs.  This contributed to me missing it.  :)
>
> There are other style(9) violations in that same file, so I didn't think
> this one was important enough to worry about, and I wanted to get the fix
> in as reviewed asap. Perhaps my judgement was faulty...

mkfs.c had fewer KNF violations than most files in the system.  With
the exception of the declarations before the functions, I could only
find formatting errors on about 13 lines using indent(1) (indent(1)
with certain options fixed about 13 lines and broke about 30).  The
global declarations are harder to check because indent(1) would misformat
them all, but they are obvioslu all misformatted because they are
mostly missing tabs.

The patch has several very obvious style bugs -- long lines.

Bruce


More information about the cvs-all mailing list