cvs commit: src/sys/vm vm_mmap.c

[Poul-Henning Kamp]

In message <00de01c33818$cff31210$52557f42 at errno.com>, "Sam Leffler" writes:
>> phk         2003/06/21 01:27:06 PDT
>> 
>>   FreeBSD src repository
>> 
>>   Modified files:
>>     sys/vm               vm_mmap.c 
>>   Log:
>>   Use a do {...} while (0); and a couple of breaks to reduce the level
>>   of indentation a bit.
>>   
>>   Revision  Changes    Path
>>   1.161     +80 -78    src/sys/vm/vm_mmap.c
>> http://cvsweb.FreeBSD.org/src/sys/vm/vm_mmap.c.diff?r1=1.160&r2=1.161
>
>I find this change truly repulsive and gratuitous.

It is a precusor to moving devices out of vnodes.  In order to get the
patch which _does_ something to be manageable, I will sort out some
minor issues first, this is one of them.

If your complaint is about the use of do { ... break; ... break; }
while (0); then launch an campaign to have it banned in style 9.

IMO it is superior to goto, and ever deepening if-else constructs.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.