cvs commit: src/usr.sbin/asf Makefile asf.c

Greg 'groggy' Lehey grog at FreeBSD.org
Sun Jun 8 00:26:39 PDT 2003


On Sunday,  8 June 2003 at  2:13:54 -0500, Juli Mallett wrote:
> * Greg Lehey <grog at FreeBSD.org> [ Date: 2003-06-08 ]
> 	[ w.r.t. cvs commit: src/usr.sbin/asf Makefile asf.c ]
>> grog        2003/06/07 23:18:13 PDT
>>
>>   FreeBSD src repository
>>
>>   Added files:
>>     usr.sbin/asf         Makefile asf.c
>>   Log:
>>   Introducing asf, a helper program for kernel debugging.
>
> This looks pretty messy and doesn't even have a license on it.

Yup.  To be added.

> Will it be tied to the build?

That was my intention.  Lots of other debugging tools are tied to the
build.

> Any reason it doesn't use the getopt(3) function, or in any way look
> like the normal BSD style for utilities?

It has a different origin.

> Please use a paths.h instead of the evilly hardcoded program paths.

paths.h is a bit of overkill for one file.  But agreed, pathname
definitions would be tidier.  Feel free to fix.

> If this won't be tied up to the build it should probably be in
> src/tools, and I'd argue it should be there anyway.

I thought about this.  In fact, it started off that way, but the way
this is intended to be used would make it inconvenient.

Greg
--
See complete headers for address and phone numbers
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20030608/12553b0d/attachment.bin


More information about the cvs-all mailing list