cvs commit: src/release Makefile

[John Baldwin]

On 05-Jun-2003 Ruslan Ermilov wrote:
> On Tue, Jun 03, 2003 at 10:17:18PM -0700, Marcel Moolenaar wrote:
>> marcel      2003/06/03 22:17:18 PDT
>> 
>>   FreeBSD src repository
>> 
>>   Modified files:
>>     release              Makefile 
>>   Log:
>>   Have the port readmes follow the same logic as buildworld. We skip
>>   doing make readmes if /tmp/.skip_ports exists. This file is created
>>   after a complete run, which avoids that we do the lengthy operation
>>   again for a rerelease.
>>   When NOPORTS or NOPORTREADMES are defined, we create the file prior
>>   to starting the release.
>>   
>>   Revision  Changes    Path
>>   1.781     +5 -5      src/release/Makefile
>> 
> I think this is not quite right.  Instead, the /tmp/.ports_done
> should be created, similar to /tmp/.world_done, when ports are
> really done.
> 
> When NOPORTS or NOPORTREADMES are defined, we should just not be
> doing the relevant parts of "make release".  And of course, it
> should be possible to run "make -DNOPORTS release" first, and be
> able to run "make rerelease" later, and get the ports built.
> 
> What do you think?

I agree.

-- 

John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/