cvs commit: src/sys/dev/lnc if_lnc.c

[Wes Peters]

On Tuesday 22 July 2003 07:17, Bruce Evans wrote:
> On Tue, 22 Jul 2003, Poul-Henning Kamp wrote:
> > Paul Richards writes:
> > >
> > >Both of those functions were called from just one place, inside
> > > the interrupt handler. Is there any reason to not inline them?
> >
> > Yes, we need to get -Werror on the kernel again, and GCC whines
> > about ridiculously large functions.
>
> I think you mean "gcc emits the requested diagnostic about functions
> that it doesn't inline, whether they are large or small".
>
> Just turn off -Winline to not request this diagnostic.
>
> > Inline should not be used unless it has a measurable impact on
> > performance.
>
> Several places, including if_lnc.c, used __inline to get cleaner code
> at no cost in performance.  Removing __inline adds a tiny cost.

Not if the compiler didn't actually *do* the inline, right?

-- 
         "Where am I, and what am I doing in this handbasket?"

Wes Peters                                              wes at softweyr.com