cvs commit: src/contrib/tar/src tar.c

Nate Lawson nate at root.org
Wed Jul 23 17:12:49 PDT 2003


On Wed, 23 Jul 2003, Peter Wemm wrote:
>   Fix an annoying bug in tar.  When it converted 'tar zcf' to 'tar -z -c -f'
>   it forgot to null terminate the new argv[] array.  If you mixed this
>   with $TAR_OPTIONS, phkmalloc and a whole bunch of other variables, you
>   could end up with a segfault.  This isn't strictly a phkmalloc victory
>   since tar walks off the end of an array rather than use uninitialized
>   malloc memory, but phkmalloc makes it easier to provoke.
>
>   Revision  Changes    Path
>   1.3       +4 -1      src/contrib/tar/src/tar.c

It is a victory for the Peter Murphy field though since without it, we
would never have triggered this bug.

-Nate


More information about the cvs-all mailing list