cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c

[Mark Murray]

Hi

There is a problem with your algorithm.

M

"Poul-Henning Kamp" writes:
> The algorithm I would like to see implemented as a pre-commit check
> for the __inline* keywords are:
> 
> 
> [1]	if (programmer thinks inline might be useful) {
> 		try compiling with inline;
> [2]		if (object code smaller) {
> 			/* inline is beneficial */

The executable could be too slow here. This forces "small code"
to be always better, at the potential expense of speed.

> 			commit it;
> 			return;
> 		} 
> 		run benchmark;
> [3]		if (code runs faster) {
> 			/* inline is beneficial */
> 			commit it;
> 			return;
> 		}
> 	}
> 	/* inline not proven beneficial */
> 	return;
--
Mark Murray
iumop ap!sdn w,I idlaH