cvs commit: src/sys/dev/lnc if_lnc.c

[Poul-Henning Kamp]

In message <20030722104524.GA80471 at survey.codeburst.net>, Paul Richards writes:
>On Tue, Jul 22, 2003 at 02:22:00AM -0700, Poul-Henning Kamp wrote:
>> phk         2003/07/22 02:22:00 PDT
>> 
>>   FreeBSD src repository
>> 
>>   Modified files:
>>     sys/dev/lnc          if_lnc.c 
>>   Log:
>>   Don't inline ridiculously very large functions.
>>   
>>   Compared to the contents of these functions, an extra function call
>>   is nano-peanuts.
>
>Both of those functions were called from just one place, inside the
>interrupt handler. Is there any reason to not inline them?

Yes, we need to get -Werror on the kernel again, and GCC whines about
ridiculously large functions.

Inline should not be used unless it has a measurable impact on
performance.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.