cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h

[John Baldwin]

On 25-Apr-2003 Sam Leffler wrote:
>> For developers, note that the locking in the code path only protects the
>> various fxp routines (fxp_start, fxp_intr, fxp_tick, ...) and is not
>> intended to serialize access to ANY external structures.  This is how it
>> should be.  Please do not copy the exact approach taken here for a little
>> while until ifnet locking is finished as there may need to be some changes
>> made to this model.
> 
> This doesn't make much sense to me.  I've locked numerous chunks of code and
> used a totally different approach: synchronize access to data structures,
> not code paths.  Perhaps you and Jeffrey Hsu need to have a private
> discussion...

Agreed, locks should be protecting data structures, not code blocks.

-- 

John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/