cvs commit: src/sbin/fsck fsck.c
Jacques A. Vidrine
nectar at FreeBSD.org
Thu Apr 24 17:52:25 PDT 2003
On Mon, Mar 03, 2003 at 01:40:32AM -0800, Juli Mallett wrote:
> jmallett 2003/03/03 01:40:32 PST
> FreeBSD src repository
> Modified files:
> sbin/fsck fsck.c
> Strip out bogus difference from when this came from NetBSD: transliterating
> upper-case alphabetical characters to lower-case ones, and spaces to dashes.
> The person who added this when bringing the code from NetBSD has no idea why
> he added it, and nobody on freebsd-fs came up with any cases where the icky
> part (the conversion of spaces to underscores) was needed. The removal of
> the upper-case conversion follows an even more obvious logic: it avoids any
> sort of namespace issues. People using StUdLy caps for filesystem names
> deserve everything they get. Otherwise, Efs and efs might be totally different
> things, but would use the same fsck. And we don't want that, right? That
> just provokes the sort of foot-shooting this would prevent.
> If you have problems with this, I'll walk you through using sed on your fstab,
> cause the only way you could have problems is if you spelled ufs as "UFS".
> Most likely, you haven't done that.
> MFC after: 1 month
> Revision Changes Path
> 1.13 +1 -17 src/sbin/fsck/fsck.c
Please back this out. If there is no fstab, the vfstype is retrieved
from the disklabel. It will likely be `4.2BSD', and fsck will try to
find /sbin/fsck_4.2BSD and fail.
Look at `FS_BSDFFS' and `fstypenames' in sys/disklabel.h to see what
(A failure of this sort was just reported to me by a coworker.)
And please don't remove any more code just because you don't know why
it is there. K PLZ THX :-)
Jacques A. Vidrine <nectar at celabo.org> http://www.celabo.org/
NTT/Verio SME . FreeBSD UNIX . Heimdal Kerberos
jvidrine at verio.net . nectar at FreeBSD.org . nectar at kth.se
More information about the cvs-all