cvs commit: src/sys/dev/an if_an.c if_an_isa.c if_an_pccard.c if_an_pci.c

[M. Warner Losh]

In message: <Pine.BSF.4.21.0304101114320.31875-100000 at root.org>
            Nate Lawson <nate at root.org> writes:
: > @@ -817,9 +806,11 @@
: >  	 */
: >  	ether_ifattach(ifp, sc->arpcom.ac_enaddr);
: >  	callout_handle_init(&sc->an_stat_ch);
: > -	AN_UNLOCK(sc);
: >  
: >  	return(0);
: > +fail:;
: > +	mtx_destroy(&sc->an_mtx);
: > +	return(error);
: >  }
: >  
: >  static void
: 
: Extra ; after "fail:"

I feel that it isn't a mistake.  A label labels a statement, and this
label labels a null statement on purpose in case the statements after
it disappear.

: > @@ -176,18 +176,26 @@
: >  	an_alloc_port(dev, sc->port_rid, AN_IOSIZ);
: >  	an_alloc_irq(dev, sc->irq_rid, 0);
: 
: You should probably check the return values of these.

Yea.  Likely.  The old driver didn't check, so I don't bother to check
them myself.

Warner