cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386
identcpu.c support.s src/sys/i386/include md_var.h src/sys/i386/isa npx.c
src/sys/ia64/ia64 support.s src/sys/powerpc/powerpc bcopy.c
src/sys/sparc64/sparc64 support.S ...
des at ofug.org
Fri Apr 4 13:09:25 PST 2003
David Schultz <das at FreeBSD.ORG> writes:
> BTW, why does this change convert bcopy from a function pointer to
> a function that jumps to the address of a pointer? This looks
> like a net gain in lines of code and a net gain in pipeline
> stalls. Is there something in particular that it makes easier?
Just code hygiene. There is no such optimization for bzero or any of
the other functions in support.s (copyin, copyout), and it required an
i386-specific declaration in <sys/systm.h>. Of course, if the
consensus is that this micro-optimization is desirable, I'll back out
this part of the patch, but in that case I'll turn the other functions
into pointers as well rather than have a mixed bag.
Dag-Erling Smørgrav - des at ofug.org
More information about the cvs-all