mount_msdosfs and longnames
Craig Rodrigues
rodrigc at crodrigues.org
Fri Nov 18 11:05:20 PST 2005
On Fri, Nov 18, 2005 at 06:50:47PM +0100, Rainer Hurling wrote:
> Looking in /usr/src/sys/fs/msdosfs/msdosfs_vfsops.c [Version 1.147 from
> 2005/10/31 15:41:20] there is a naming discrepancy against the manpage:
> supported options are 'shortname' and 'longname' without s. I hope I did
> not misunderstood this.
There was a naming discrepancy between the userland mount_msdosfs
utility, and the implementation of the option in the
msdos_vfsops.c for quite a while which was hidden in the mess
of the old mount code. When I converted mount_msdosfs to use nmount(),
this discrepancy was uncovered.
Can you try this patch?
Index: msdosfs_vfsops.c
===================================================================
RCS file: /home/ncvs/src/sys/fs/msdosfs/msdosfs_vfsops.c,v
retrieving revision 1.147
diff -u -u -r1.147 msdosfs_vfsops.c
--- msdosfs_vfsops.c 31 Oct 2005 15:41:20 -0000 1.147
+++ msdosfs_vfsops.c 18 Nov 2005 19:02:40 -0000
@@ -81,7 +81,7 @@
"from",
"export",
"uid", "gid", "mask", "dirmask",
- "shortname", "longname", "win95",
+ "shortname", "shortnames", "longname", "longnames", "win95",
"kiconv", "cs_win", "cs_dos", "cs_local",
NULL
};
@@ -163,8 +163,12 @@
pmp->pm_dirmask = v & ALLPERMS;
vfs_flagopt(mp->mnt_optnew, "shortname",
&pmp->pm_flags, MSDOSFSMNT_SHORTNAME);
+ vfs_flagopt(mp->mnt_optnew, "shortnames",
+ &pmp->pm_flags, MSDOSFSMNT_SHORTNAME);
vfs_flagopt(mp->mnt_optnew, "longname",
&pmp->pm_flags, MSDOSFSMNT_LONGNAME);
+ vfs_flagopt(mp->mnt_optnew, "longnames",
+ &pmp->pm_flags, MSDOSFSMNT_LONGNAME);
vfs_flagopt(mp->mnt_optnew, "kiconv",
&pmp->pm_flags, MSDOSFSMNT_KICONV);
--
Craig Rodrigues
rodrigc at crodrigues.org
More information about the freebsd-current
mailing list