ng_split
Ruslan Ermilov
ru at FreeBSD.org
Wed Nov 16 04:02:05 PST 2005
On Wed, Nov 16, 2005 at 12:41:48PM +0100, Michael Reifenberger wrote:
> Hi,
> the change below doesnt look canonical to me,
> since it contains an NG at the beginning allready
> and no other ng node type does this.
>
You're right about this, but you probably read the patch in reverse
way. My fix makes the name match the rest of the world:
$ grep NGM_.*_COOKIE *.h | grep NGM_NG | wc -l
0
$ grep NGM_.*_COOKIE *.h | grep -v NGM_NG | wc -l
46
Furthemore, it was necessary to add this type to libnetgraph/debug.c,
that's how I noticed it wasn't canonical.
> Furthermore it breaks -current and RELENG_6 at least.
>
How?
> Can we revert it?
>
I fail to see a reason at the moment.,
> Index: ng_split.h
> ===================================================================
> RCS file: /home/ncvs/src/sys/netgraph/ng_split.h,v
> retrieving revision 1.4
> retrieving revision 1.5
> diff -u -r1.4 -r1.5
> --- ng_split.h 7 Jan 2005 01:45:39 -0000 1.4
> +++ ng_split.h 25 Oct 2005 20:56:12 -0000 1.5
> @@ -25,7 +25,7 @@
> * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF
> * SUCH DAMAGE.
> *
> - * $FreeBSD: src/sys/netgraph/ng_split.h,v 1.4 2005/01/07
> 01:45:39 imp Exp $
> + * $FreeBSD: src/sys/netgraph/ng_split.h,v 1.5 2005/10/25
> 20:56:12 ru Exp $
> *
> */
>
> @@ -35,7 +35,7 @@
>
> /* Node type name and magic cookie */
> #define NG_SPLIT_NODE_TYPE "split"
> -#define NGM_NG_SPLIT_COOKIE 949409402
> +#define NGM_SPLIT_COOKIE 949409402
Cheers,
--
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20051116/8672bb82/attachment.bin
More information about the freebsd-current
mailing list