libexec/ftpd/ftpd.c and pam

Dag-ErlingSmørgrav des at des.no
Wed Jan 28 04:48:54 PST 2004


Eric van Gyzen <vangyzen at stat.duke.edu> writes:
> The auth_pam function in src/libexec/ftpd/ftpd.c defines a local variable
>     pam_handle_t *pamh = NULL;
> which shadows the same variable in the global scope.  This seems 
> unintentional, because the global pamh is never initialized by pam_start(), 
> so the other functions in ftpd.c always operate on a NULL pam_handle_t.

you're right...  though the only impact is that pam_open_session()
never gets called.  Could you please file a PR and Cc: me?

DES
-- 
Dag-Erling Smørgrav - des at des.no


More information about the freebsd-current mailing list