simplifying linux_emul_convpath()
Tim Robbins
tjr at freebsd.org
Wed Jan 14 06:08:30 PST 2004
On Wed, Jan 14, 2004 at 05:08:51AM -0800, Don Lewis wrote:
> I just stumbled across a vnode locking violation in
> linux_emul_convpath(). Rather than locking and unlocking each vnode for
> the VOP_GETATTR() calls, is there any reason that this code should not
> be simplified to just compare the vnode pointers rather than fetching
> the vnode attributes and comparing the attributes for equality.
I'm having trouble convincing myself that comparing vnode pointers
would work with stackable filesystems. Then again, null_getattr()
changes va_fsid, so linux_emul_convpath() may not handle stacking
properly right now anyway.
Tim
More information about the freebsd-current
mailing list